validation: add check for namespace path #192
Conversation
cmd/ocitools/validate.go
Outdated
| mountExists = true | ||
| } | ||
| } else { | ||
| if hostCheck { |
There was a problem hiding this comment.
} else if hostCheck { to avoid a layer of nesting?
There was a problem hiding this comment.
On 08/17/2016 11:42 AM, W. Trevor King wrote:
|} else if hostCheck {| to avoid a layer of nesting?
I ever thought about this.
But, it seems they should not in the seem level.
So, I did not write like this.
There was a problem hiding this comment.
On Tue, Aug 16, 2016 at 08:43:42PM -0700, Ma Shimiao wrote:
08/17/2016 11:42 AM, W. Trevor King:
|} else if hostCheck {| to avoid a layer of nesting?
I ever thought about this.
But, it seems they should not in the seem level.
It doesn't really matter, so if it feels too strange go ahead and
leave it in there. It just reads more clearly to me with fewer
levels.
Signed-off-by: Ma Shimiao <mashimiao.fnst@cn.fujitsu.com>
Mashimiao
force-pushed
the
add-namespace-path-check
branch
from
4d5210b to
c8b8c73
Compare
|
ping @mrunalp , @liangchenye |
|
LGTM |
|
c8b8c73 looks good to me.
|
Signed-off-by: Ma Shimiao <mashimiao.fnst@cn.fujitsu.com> Backported to v1.0.0.rc1 from c8b8c73 opencontainers#192 (cherry-pick applied cleanly). Signed-off-by: W. Trevor King <wking@tremily.us>
Signed-off-by: Ma Shimiao <mashimiao.fnst@cn.fujitsu.com> Backported to v1.0.0.rc1 from c8b8c73 opencontainers#192 (cherry-pick applied cleanly). Signed-off-by: W. Trevor King <wking@tremily.us>
4 participants
Signed-off-by: Ma Shimiao mashimiao.fnst@cn.fujitsu.com